Quoted By:
By virtue of the amount of practice you can get, whatever one is the current one.
If you want the most FUN one, that's very personal and subjective. It also depends on your format, singles or doubles, and Smogon or official.
I actually really enjoyed gen 6 & 8 VGC, and I used to play a lot of casual doubles matches in gen 4.