>>19298563I went away for a bit, sorry.
Weavile is an Ice/Dark Pokemon with high speed and attack. Naturally, you'll want him to have an Ice and a Dark type move for STAB coverage, the other two moves are just icing.
Out of the ice moves worth using, he has access to Ice Shard, Ice Punch, and now, Icicle Crash.
When choosing your Ice moves, Ice Shard has 40 BP, 100 Accuracy, and +1 Priority.
Ice Punch has 75 BP, 100 Accuracy, and 10% chance to freeze
Icicle Crash has 85 BP, 90 Accuracy, and a 30% chance to flinch.
Weavile already has insane speed, so if you give him a jolly nature with 252 speed EVs or a Choice Scarf, nothing is going to be outspeeding him. This makes Icicle Shard not worth using. However, if you give him an Adamant Nature and something like a Life Orb, then it becomes a possibility that Weavile could be outspeeded, so Ice Shard then becomes almost mandatory on him. If you go for the speedy build, then it comes down to Ice Punch or Icicle Crash. As said before, there are no damage calculation scenarios that you would ever normally face where Icicle Crash would OHKO a Pokemon that Ice Punch would 2HKO. Ice Punch is also way safer because of it's 100 instead of 90 accuracy. Agian, 10% freeze and 30% flinch aren't really reliable, but in most (if not all) situations, freezing if preferable to flinching, especially when Steadfast and Inner Focus exist on common Pokemon like Lucario who might predict and switch into your ice attack.
Basically, if LK and Knock Off become move tutor-able again, nothing changes. You only have room for one Ice Type move, and Ice Punch/Shard trump Icicle Crash in almost every situation. Unless you use Power Up Punch/Swords Dance and need Icicle Crash for maximum damage, Ice Punch/Shard is the way to go.