Team building? Team Building.

I'm pretty new to the competitive side of pokémon, some of it feels a little asinine, with various clauses from Smogon like no more than 1 sleeping pokémon, no evasion moves etc.., but I'd still like to give it a go and see where I end up.

I've drawn up what I'd like to do for a team, asked a friend of mine who does competitive a lot, she says it's fairly solid, gave me a few pointers. Wanted to share here, get some feedback, learn about the general process of proper team building and what traps to avoid

I should also mention that because I was/kind of still am a poor fag, I basically started with Gen 3, missed 4 and 5, and jumped straight to ORAS Gen 6.

I came up with this team months ago, and have forgotten a few details, but will try to reconstruct as best I can

Anyway, my team concept is as follows:

Rain based team

Politoed
Ability: Drizzle
Hold Item: Damp Rock
Move List: Scald, Ice-Beam, Protect, Encore

Vaporeon
Ability: Hydration
Hold Item: Leftovers (Optional)
Move List: Toxic, Scald, Ice-Beam, Rest

Ludicolo
Ability: Swift Swim
Hold Item: Leftovers
Move List: Giga-Drain, Rain Dance, Ice Beam, Hydro-Pump

Scizor
Ability: Technician
Hold Item: Scizorite
Move List: Swords Dance, Brick Break, Bullet Punch, X-Scissor

Zapdos:
Ability: Pressure
Hold Item: Life Orb
Move List: Thunder, Volt Switch, Thunder Wave, Roost

Swampert:
Ability: Torrent
Hold Item: Leftovers/Assault Vest (Optional)
Move List: Stealth Rock/Avalanche (Assault Vest), Hammer Arm, Waterfall, Earthquake