as a whole, gen 4 is uncontested
no other green has two complete games like platinum and hgss, filled with content and an endgame challenge in the frontier
the regions are vast and interesting to explore, with many hidden areas that reward exploration
gen 3 would be next best, since emerald is just as good and frlg has enough going on
other than these two knockout gens, I think pokemon has absolutely gotten better each generation
4 > 3 > 7 > 6 > 5 > 2 > 1 is the best I can think of, but maybe gen 6 deserves some praise for having two regions while 5 and 7 stuck with just one