Favorite generation as a whole.
This includes:
>Mainline(+remakes made during it's life)
>Card Game
>Spin off
>Anime
>Merchandise
For me my favorite mainline is R/S/E and LgFr are obviously great because I love Kanto
My most nostalgic time in the card game is during Gen 3 with the Magma and Aqua cards
My favorite Spin Offs are from gen 4
My favorite anime is from gen 1
And my favorite merchandise is from gen 1
Overall, my bias tips in favor of Gen 3, because that's when I was finally Old enough to read and understand pokemon, prior to that I just liked the pictures and would ask my mom to tell me what the game said.