>>55405728A few obvious reasons.
1. It's not a stable job. Your income is directly proportionate to how many other people are in your area also battling.
2. It isn't guaranteed money. You actually have to win battles consistently for it to be worth it financially. And if you lose you lose money.
3. The time and financial investment you have to spend on your pokemon. That includes training them up to a high level, teaching them new moves. Buying them food and water and held items that improve their battle performance. It's kind of a huge investment.
4. It's an inherently nomadic hobby. I assume settling down in a house is the antithesis to being a trainer. You gotta go where the battles are and the money is so staying in one spot might be detrimental once you milk the local trainers dry.
That's like saying "why doesn't everyone just go to fighting game tournaments instead of a full time job?"