>>55805196rock isn't in a terrible spot, its a middle of the pack type that is quite potent with sandstorm support and combos very smoothly with ground for excellent offensive coverage. it has some really common weaknesses in a vacuum and most of the pokemon aren't retard proof like steel types but depending on the regulation format rock types can do fine. they are hard to use currently because the meta is full of fighting, water, grass, and ground types. it IS fucking weird that it excels so much more as an offensive type compared to a defensive type from a conceptual standpoint though.
it is pretty funny GF "fixed" ice types by just doubling down on it being an analogue to rock with snow in place of sand and the coverage relationship being ice-water instead of rock-ground, and the types are similarly frequently designed as defensive pokemon despite the type leaning way more into offense